Add support for federated authentication with Apple Business Manager#465
Open
daltonclaybrook wants to merge 6 commits into
Open
Add support for federated authentication with Apple Business Manager#465daltonclaybrook wants to merge 6 commits into
daltonclaybrook wants to merge 6 commits into
Conversation
Contributor
Author
|
Hey @MattKiazyk, is there any appetite for merging this change? I know my team would really appreciate it. |
|
Any updates? |
Contributor
Author
|
@kishjayson None from me. Just waiting for approval... 😕 |
|
any news on this? |
|
This would be super helpful for my team too 🙏 |
Contributor
|
There's a beta version out that integrates this in (sorry for not merging this one in - there's a lot of refactoring that's gone into both cli and UI - and it was simpler to grab and integrate with the changes) If you could test that out. That would be amazing. Plan to get this out before WWDC and beta season. |
|
I've just tested it and it works well 🙏 thanks for all the work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #260 and #378
This PR adds support for federated authentication with Apple Business Manager. During the login flow, after the user has entered their Apple ID, the app now sends a network request to
https://idmsa.apple.com/appleauth/auth/federate/validateto check whether the provided Apple ID uses federated auth. If so, instead of prompting for the user's password, the app now provides instructions for completing auth. The app opens a web browser where the user completes authentication with their identity provider and is redirected to a blank page. Finally, the user copies the URL from the browser, pastes it into their terminal, and can perform authenticated requests.